Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy lint type_complexity #74

Merged
merged 2 commits into from
Jan 6, 2023
Merged

chore: fix clippy lint type_complexity #74

merged 2 commits into from
Jan 6, 2023

Conversation

theHamsta
Copy link

Also use a proper type for often repeated Vec<(Rc<Highlight>, Vec<String>)>. I called it HighlightedLine consisting of multiple HighlightedRanges. The previous code referred toVec<(Rc<Highlight>, Vec<String>)> often as Content if that's a better name.

@theHamsta theHamsta force-pushed the type-complexity branch 2 times, most recently from 7459ede to de99027 Compare January 5, 2023 20:50
Lyude
Lyude requested changes Jan 6, 2023
View reviewed changes
src/ui_model/model_layout.rs Outdated Show resolved Hide resolved
@theHamsta theHamsta requested a review from Lyude January 6, 2023 19:22
@Lyude Lyude mentioned this pull request Jan 6, 2023
Open
@Lyude Lyude merged commit da7c176 into Lyude:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyude Lyude Lyude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theHamsta @Lyude